VNC/SPICE should listen on all interfaces

Until now, we only allowed VNC/SPICE console to listen on connections coming from localhost. This however breaks "Desktop viewer" use case where user wants to download a virt-viewer file to a client computer and open a VNC/SPICE console connected to a remote VNC server. Fixes cockpit-project#1078
skobyda · May 23, 2023 · 0fbf07e · 0fbf07e
1 parent c905ae2
commit 0fbf07e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/src/scripts/install_machine.py b/src/scripts/install_machine.py
@@ -46,8 +46,8 @@ def get_graphics_capabilies(connection):
 
 def prepare_graphics_params(connection):
     graphics_config = {
-        'spice': {'listen': '127.0.0.1'},
-        'vnc': {'listen': '127.0.0.1'}
+        'spice': {'listen': '0.0.0.0'},
+        'vnc': {'listen': '0.0.0.0'}
     }
     try:
         # Configparser needs a default section
@@ -57,12 +57,12 @@ def prepare_graphics_params(connection):
         config = configparser.ConfigParser()
         config.read_string(config_string)
 
-        graphics_config['spice']['listen'] = config['dummy_section'].get('spice_listen', '127.0.0.1')
+        graphics_config['spice']['listen'] = config['dummy_section'].get('spice_listen', '0.0.0.0')
         spice_password = config['dummy_section'].get('spice_password', None)
         if spice_password is not None:
             graphics_config['spice']['password'] = spice_password
 
-        graphics_config['vnc']['listen'] = config['dummy_section'].get('vnc_listen', '127.0.0.1')
+        graphics_config['vnc']['listen'] = config['dummy_section'].get('vnc_listen', '0.0.0.0')
         vnc_password = config['dummy_section'].get('vnc_password', None)
         if vnc_password is not None:
             graphics_config['vnc']['password'] = vnc_password

diff --git a/test/check-machines-consoles b/test/check-machines-consoles
@@ -177,7 +177,6 @@ class TestMachinesConsoles(VirtualMachinesCase):
                                     ".*Connection reset by peer")
         self.allow_browser_errors("Disconnection timed out.")
         self.allow_journal_messages(".* couldn't shutdown fd: Transport endpoint is not connected")
-        self.allow_journal_messages("127.0.0.1:5900: couldn't read: Connection refused")
 
     def testBasic(self):
         b = self.browser

diff --git a/test/check-machines-create b/test/check-machines-create
@@ -475,15 +475,15 @@ vnc_password= "{vnc_passwd}"
             TestMachinesCreate.VmDialog(self, sourceType='file',
                                         storage_pool=NO_STORAGE,
                                         location=config.NOVELL_MOCKUP_ISO_PATH),
-            vnc_listen, "127.0.0.1", vnc_passwd, None)
+            vnc_listen, "0.0.0.0", vnc_passwd, None)
 
-        # Ensure that missing qemu.conf would not crash the script but just pick the 127.0.0.1 default value
+        # Ensure that missing qemu.conf would not crash the script but just pick the 0.0.0.0 default value
         m.execute("rm /etc/libvirt/qemu.conf")
         runner.createAndVerifyQemuConfParsedTest(
             TestMachinesCreate.VmDialog(self, sourceType='file',
                                         storage_pool=NO_STORAGE,
                                         location=config.NOVELL_MOCKUP_ISO_PATH),
-            "127.0.0.1", "127.0.0.1", None, None)
+            "0.0.0.0", "0.0.0.0", None, None)
 
     @skipImage("TODO: Arch Linux has no iscsi support", "arch")
     def testCreateThenInstall(self):
@@ -515,7 +515,7 @@ vnc_password= "{vnc_passwd}"
             target_iqn = "iqn.2019-09.cockpit.lan"
             self.prepareStorageDeviceOnISCSI(target_iqn)
             cmd = [
-                "virsh pool-define-as iscsi-pool --type iscsi --target /dev/disk/by-id --source-host 127.0.0.1 --source-dev {0}",
+                "virsh pool-define-as iscsi-pool --type iscsi --target /dev/disk/by-id --source-host 0.0.0.0 --source-dev {0}",
                 "ls -la /dev/disk/by-id",
                 "virsh pool-start iscsi-pool"
             ]