-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed translated states from translation files #576
base: main
Are you sure you want to change the base?
removed translated states from translation files #576
Conversation
by removing the states from the translation files, HomeAssistant should use its default translation for binary_states according to their device_class. Only, if a language is not available in HomeAssistant itself, the state should be default in english.
json error will be fixed... sorry ^^ |
fixed some issues within the json file
Have you tested this, and if so, on what version of HA and in which language? Last time i tried this, it simply did english for all untranslated states. |
I did some tests with single sensors, before I made the changes. After rebooting, everything looks as expected and is using the default language set in HA did you maybe had the state translation still in your english json file? Only, if there's no translation given at all, it will use its own translations. |
Thanks for testing this, and for sharing your findings. 🙏 I will re-test this myself to see if we can for instance use a per-entity approach, where most are default from HomeAssistant, and some are translated. |
this should already be given in the current translation files. Anything else that will have multiple states will be done with these translation files - since those are not translated by HA per default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this, and indeed works as intended, except for the device tracker.
Can you fix the merge conflicts as well?
"name": "Position", | ||
"state": { | ||
"home": "Home", | ||
"not_home": "Away", | ||
"vehicle_in_motion": "Motion detected" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We specifically have this feature for detecting the vehicle is in motion and have this state translated. Please don't remove this one
by removing the states from the translation files, HomeAssistant should use its default translation for binary_states according to their device_class.
Only, if a language is not available in HomeAssistant itself, the state should be default in english.
fix #384