-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21 remove vocabs from deleted branches #22
Conversation
@Phu2 Please deploy to test for review. You will have to set a new env variable (sth like Feel free to message me if we want to try out the cleanup. |
Deployed to test. Cleanup works great with Added RewriteRule for the new endpoint: |
Note: I renamed the endpoint to |
Assigning @acka47 now for functional review. The cleanup part was already successfully tested with Phu. What you can test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After approving I realized:
As a result, I imagine it to look something like this: {
"repository":"https://github.com/acka47/testing-skohub-vocabs",
"vocabulary":"https://test.skohub.io/acka47/testing-skohub-vocabs/heads/master/",
"latestBuild":{
"timestamp":"2024-02-07T12:06:20.475Z",
"id":"https://test.skohub.io/build?id=93cc2ad1-2d0a-4f19-971e-b3a4d764614b"
}
} |
@Phu2 Please deploy on test system. Be aware of the above mentioned change in naming the endpoint. |
Deployed to test and changed RewriteRule for renamed endpoint https://test.skohub.io/vocabs |
This looks much better but one point isn't adressed yet:
I'd like to see |
That is related to deployment. |
Changed and redeployed to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now. I love it. +1
This PR adds the feature to remove unused vocabularies (#21).
You can make a dry run with
npm run cleanup-dist:dry
To actually remove the unused vocabularies run
npm run cleanup-dist
The output of this script as well as the rebuild-vocabs logs are now written to a log file
log.log
. (#5)There is now also an endpoint to get all currently served vocabularies:
/currentVocabs
.It will output information like this:
Besides I was able to prettify the build logs and remove those strange character:
Before:
After:
Closes #21
Closes #5