Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detach kernel driver (Fix #22) #28

Closed

Conversation

felfert
Copy link
Collaborator

@felfert felfert commented Apr 17, 2023

Hi Sebastian,

Unfortunately with your latest changes in master, cherryrgb_cli crashes here (will file a separate Issue for that tommorow).
Therefore my fix for #22 is NOT against master, but against the tag 0.2.3

@skraus-dev
Copy link
Owner

skraus-dev commented Apr 18, 2023

Thanks, good find! Did not realize the kernel driver is responsible for handling the special keys..

Unfortunately with your latest changes in master, cherryrgb_cli crashes here (will file a separate Issue for that tommorow).

Those crashes should be fixed with latest master.. but out of scope for this PR anyways.

Therefore my fix for #22 is NOT against master, but against the tag 0.2.3

I am curious, as this never occured to me: How is a PR towards master, not based off current HEAD gonna be merged?
Other than rebasing it of course...

What am I missing?

@skraus-dev skraus-dev changed the title Fix #22 Auto-detach kernel driver (Fix #22) Apr 18, 2023
@felfert
Copy link
Collaborator Author

felfert commented Apr 18, 2023

Those crashes should be fixed with latest master.. but out of scope for this PR anyways.

In that case, I will make another PR against master...

Repository owner deleted a comment from tuxuser Apr 18, 2023
@skraus-dev
Copy link
Owner

No worries, I can just rebase here. I was honestly wondering about the way to merge a PR against non-HEAD tho, how it is expected to deal with. Does it tell the maintainer "I only tested and can verify a working state until this tag" ?

@felfert
Copy link
Collaborator Author

felfert commented Apr 18, 2023

No worries, I can just rebase here. I was honestly wondering about the way to merge a PR against non-HEAD tho, how it is expected to deal with. Does it tell the maintainer "I only tested and can verify a working state until this tag" ?

Well if you look at the diff, a simple rebase wont suffice, because the error handling changed after that tag. The
PR still uses the old one..
Anyway, I'm almost ready (just filling out the PR template...)

@felfert felfert mentioned this pull request Apr 18, 2023
6 tasks
@felfert felfert closed this Apr 18, 2023
@felfert felfert deleted the fix-detach-attach-kerneldriver branch April 27, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants