Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt workflows to #35 #38

Closed
wants to merge 1 commit into from
Closed

Conversation

felfert
Copy link
Collaborator

@felfert felfert commented Apr 30, 2023

  • Install build dependencies when building the UHID stuff.
  • Build UHID stuff on native linux only for now.

Description

See my last comment in #35

Fixes workflow issues with #35

Type of change

  • I have performed a self-review of my own code

- Install build dependencies when building the UHID stuff.
- Build UHID stuff on native linux only for now.
@felfert
Copy link
Collaborator Author

felfert commented Apr 30, 2023

BTW: I just noticed, that #39 (a doc-only) PR triggered the CI checks. You probably want to ignore those changes like this:

on:
  push:
    branches: [master]
  pull-request:
    paths-ignore:
      - 'README.md'
      - 'docs/**'

Docs for this feature: here

@felfert
Copy link
Collaborator Author

felfert commented Apr 30, 2023

I dont give up. This is just a fix for the existing CI/CD to handle #35. I will read some more docs and will give it a try later...

@felfert
Copy link
Collaborator Author

felfert commented May 3, 2023

This is what I have so far: https://github.com/felfert/cherryrgb-rs/actions/runs/4869978304

Need some more polish, but works nicely. I ditched the cross compilation and build the "foreign" archs within
native containers run in qemu. This eleminates the problems with libclang. Also the strip part is unified
(no cross binutils required any more). Drawback is longer build times for aarch64:

Matrix build:

  • Full initial build (no cached container image and no .cargo or target cached): ~25min
  • With container image and cache hit : ~4min

@felfert felfert mentioned this pull request May 3, 2023
11 tasks
@felfert
Copy link
Collaborator Author

felfert commented May 4, 2023

Closing this. obsoleted by #41

@felfert felfert closed this May 4, 2023
@felfert felfert deleted the fix-workflows branch May 10, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant