Echo/fix omission with break token #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delxen
force-pushed
the
echo/fix-omission-with-break-token
branch
from
792fa4d to
5716088
Compare
delxen
force-pushed
the
echo/fix-omission-with-break-token
branch
from
87d01ff to
4bfcc63
Compare
delxen
force-pushed
the
echo/update-gems-and-cleanup
branch
from
e278c9b to
ef78ec4
Compare
delxen
force-pushed
the
echo/fix-omission-with-break-token
branch
from
4bfcc63 to
14bf9ab
Compare
delxen
force-pushed
the
echo/update-gems-and-cleanup
branch
from
ef78ec4 to
e124272
Compare
delxen
force-pushed
the
echo/fix-omission-with-break-token
branch
from
14bf9ab to
d7e6d3f
Compare
mkousta
reviewed
Apr 19, 2019
| @@ -242,4 +242,20 @@ def truncate(html, opts = {}) | |||
| to eq '<h1>hello <!-- stuff --> and <!-- la -->...</h1>' | |||
| end | |||
| end | |||
|
|
|||
| context 'when truncating by break_token and using a omission' do | |||
There was a problem hiding this comment.
[Minor] a -> an omission, but I suggest 'when a custom break_token and omission options are used' for consistency with the rest of the file and also discard the first expectation. I think it has already been tested with various break_token values above.
There was a problem hiding this comment.
Done!
Removed the first expect (indeed it was tested above) and fixed the test description.
Plus I fixed all rubocop warnings in the spec file according to yogurt rubucop.yml
|
LGTM |
mkousta
approved these changes
Apr 19, 2019
added 2 commits
April 22, 2019 11:35
When using break_token, omissions was not added in the truncated html. Fix based on hgmnz/truncate_html#57. Issue described here hgmnz/truncate_html#52
delxen
force-pushed
the
echo/fix-omission-with-break-token
branch
from
d7e6d3f to
3aa6448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using break_token, omissions were not added in the truncated html.
Based on this fix.
Issue described here