-
Notifications
You must be signed in to change notification settings - Fork 107
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Parallelize the
TableVectorizer
column-wise (#592)
* fall back to pandas if no datetime format is found * change changelog * first working version * add tests * update changelog * typo * copy transformer when split between columns to avoid conflict * update changelog * fix bug with repeated transformer * split and merge * more tests * fix test * also split self.transformers_ to parallelize transform * add _split to minhashencoder * cleaning * clean test * fix wrong merge * fix wrong merge * Apply suggestions from code review type hints Co-authored-by: Lilian <[email protected]> * Update skrub/_utils.py Co-authored-by: Lilian <[email protected]> * apply Lilian's suggestions * add future annotation to avoid circular import in type hints * add docstring * Update skrub/_table_vectorizer.py Co-authored-by: Lilian <[email protected]> * type hint * revert change * first batch of Vincent's suggestions * use tags * compare fitted transformers better * talk about tags in changelog * run precommit checks * get rid of _transformers_original * clean tests * Apply suggestions from code review Co-authored-by: Vincent M <[email protected]> * _parallel_on_columns * explain transformers vs transformers_ * split merge into two functions * add tests to check that splitting doesn't prevent resetting transformers * Apply suggestions from code review Co-authored-by: Vincent M <[email protected]> * combine merge_unfitted and merge_fitted and move _split outside of class * don't return empty new_transformer_to_input_indices * remove future warning * add docstrings * fix merge * fix test * Update skrub/_table_vectorizer.py Co-authored-by: Vincent M <[email protected]> * fix type hints --------- Co-authored-by: Lilian <[email protected]> Co-authored-by: Vincent M <[email protected]>
- Loading branch information
1 parent
df16844
commit f981247
Showing
9 changed files
with
839 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.