remove use of matplotlib.rc_context #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was going to merge it now but still needs a changelog entry so putting back in draft mode |
jeromedockes
added a commit
to jeromedockes/skrub
that referenced
this pull request
Dec 11, 2024
TheooJ
pushed a commit
that referenced
this pull request
Dec 11, 2024
* bump version after 0.4.0 (#1162) * DOC Correct typo in TableReport docstring (#1168) * Add codespell support (#1126) * add python 3.13 (#1170) * add sections for the next release's changelogs (#1183) * Add a verbosity parameter to TableReport to control the printing of messages in stdout when opening summary report (#1182) * add verbose parameter to print_display to toggle on or off printing of progress messages when generating table report (#1188) * DOC add example for Cramer V for column_associations (#1186) * ENH adding alias "regression" and "classification" (#1180) * Bump codecov/codecov-action from 5.0.7 to 5.1.1 in the actions group (#1191) * remove use of matplotlib.rc_context (#1172) * MAINT adapt for scikit-learn 1.6 (#1135) * Revert "MAINT adapt for scikit-learn 1.6 (#1135)" (#1194) This reverts commit 18af508. * MAINT compatibility sklearn 1.6.0 (#1169) * MAINT fix nightly builds (#1193) * Updating contributing doc to add more detail on how to start (#1185) * FIX better display of object columns with multi-line repr in tablereport (#1196) * update changelog --------- Co-authored-by: Matt J. <[email protected]> Co-authored-by: Yaroslav Halchenko <[email protected]> Co-authored-by: priscilla baah <[email protected]> Co-authored-by: Reshama Shaikh <[email protected]> Co-authored-by: mrastgoo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Riccardo Cappuzzo <[email protected]>
TheooJ
pushed a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1171
matplotlib.rc_context seems to prevent the inline display of plots in jupyter notebooks in some cases
this removes the use of this context manager
the context manager does not seem to do anything fancier than the try/finally statement in this PR, but the difference is here we only set the key we are interested in
svg.fonttypewhereas upon exitrc_contextupdates all params except the backend:https://github.com/matplotlib/matplotlib/blob/v3.9.3/lib/matplotlib/__init__.py#L1142-L1196