-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating contributing doc to add more detail on how to start #1185
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ec37e13
Fixing changelog with correct account
rcap107 b3dae47
Merge remote-tracking branch 'upstream/main'
rcap107 99e5450
Merge branch 'main' of github.com:skrub-data/skrub
rcap107 4a39f36
Merge branch 'main' of github.com:skrub-data/skrub
rcap107 ee2f739
Merge branch 'main' of github.com:skrub-data/skrub
rcap107 e01637c
Merge branch 'main' of github.com:skrub-data/skrub
rcap107 0628fc3
Updating contrib
rcap107 53d143c
Added info on creating a new venv
rcap107 5b106df
Adding a few more improvements
rcap107 fafd78d
Slightly reworded readme
rcap107 57f6a36
Updating readme
rcap107 1bd1482
Adding a note on warnings in the tests
rcap107 d5466bf
Merge branch 'main' of github.com:skrub-data/skrub into contribute
rcap107 de1b7d9
A couple of small fixes
rcap107 09d0090
Removed a line
rcap107 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I add the specific commands for both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as they're quite short I would say yes, this one someone following along can just copy-paste without needing to follow the links