Code

[MRG] Fix the match score scaling#802

Code

Merged

Vincent-Maladiere merged 17 commits intoskrub-data:mainskrub-data/skrub:mainfrom jeromedockes:matching_score_scalingjeromedockes/skrub:matching_score_scalingCopy head branch name to clipboardNov 8, 2023

+57-47

Commits

Commits on Oct 19, 2023

• fix the match score scaling

  jeromedockes

  committed
  aa19518

  Copy full SHA for aa19518

Commits on Oct 20, 2023

• changes

  jeromedockes

  committed
  03b27fe

  Copy full SHA for 03b27fe

• add non-regression test for skrub-data#764

  jeromedockes

  committed
  5fff3f1

  Copy full SHA for 5fff3f1

• check matching_score

  jeromedockes

  committed
  681e6e3

  Copy full SHA for 681e6e3

• do not subtract min distance ie best score is not necessarily 1

  jeromedockes

  committed
  45a5771

  Copy full SHA for 45a5771

• update changes

  jeromedockes

  committed
  fb9eb3f

  Copy full SHA for fb9eb3f

Commits on Oct 30, 2023

• Merge remote-tracking branch 'upstream/main' into matching_score_scaling

  jeromedockes

  committed
  cbb83d9

  Copy full SHA for cbb83d9

• update example

  jeromedockes

  committed
  2ec7055

  Copy full SHA for 2ec7055

Commits on Oct 31, 2023

• fix overfitting in example

  jeromedockes

  committed
  89a35a7

  Copy full SHA for 89a35a7

• Merge remote-tracking branch 'upstream/main' into matching_score_scaling

  jeromedockes

  committed
  fac938d

  Copy full SHA for fac938d

• add note

  jeromedockes

  committed
  a49e0a6

  Copy full SHA for a49e0a6

• correct comment

  jeromedockes

  committed
  307674b

  Copy full SHA for 307674b

• update comment

  jeromedockes

  committed
  8bfee9f

  Copy full SHA for 8bfee9f

Commits on Nov 2, 2023

• typo

  jeromedockes

  committed
  f98478a

  Copy full SHA for f98478a

• Merge remote-tracking branch 'upstream/main' into matching_score_scaling

  jeromedockes

  committed
  fbef8e0

  Copy full SHA for fbef8e0

• iter example

  jeromedockes

  committed
  b1d2f7b

  Copy full SHA for b1d2f7b

• Merge remote-tracking branch 'upstream/main' into matching_score_scaling

  jeromedockes

  committed
  87d8bd4

  Copy full SHA for 87d8bd4