Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT update pre-commig-config #929

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Jun 6, 2024

Update the pre-commit configuration.

The idea is to:

  • use the same as scikit-learn
    • update the version
    • use ruff and black instead of isort and flake8
  • centralize a bit more the config into the pyproject.toml
  • remove mypy since it is not used.

I kept the traceback over 88 characters in this PR but I needed to switch from # noqa to # noqa: E501 at a different location.

@glemaitre
Copy link
Member Author

@jeromedockes there was not real changes in the file that should affect the code. This is only cosmetic due to updating the tools.

Copy link
Member

@jeromedockes jeromedockes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this maintenance @glemaitre

@glemaitre
Copy link
Member Author

I see this is going towards the direction of #708

@jeromedockes
Copy link
Member

merging. here come the git conflicts :D

@jeromedockes jeromedockes merged commit 0e88eac into skrub-data:main Jun 7, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants