Unique, periodically refreshed hash #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a unique hash that is refreshed every second, so certains browsers don't detect multiple separators with the same name as duplicates. The typeof check is there because crypto.randomUUID() has only been standard for a couple years, and as a placeholder in case a polyfill is ever to be used
|
This is a great idea and the changes look good. Let me do some tests and then I think this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a unique hash that is refreshed every second, so certains browsers don't detect multiple separators with the same name as duplicates and remove them.
The typeof check is there because crypto.randomUUID() has only been standard/implemented for a couple years (and I wanted to be extra cautious), and as a placeholder in case a polyfill is ever to be used; so it will work exactly the same as before in case someone is using a really outdated browser.
Should address #12