Fix handling input_size with multi-input #166
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While dealing with multi-input, the current implementation calculates the number of elements in input as the product of all dimensions in all inputs, I believe this is not accurate.
For example, if we have input1 with dimensions [1,5,5] and input2 with dimensions [1,10,10]:
Current implementation: number of elements = 1 * 5 * 5 * 1 * 10 * 10 = 2500 elements
Where it should be: number of elements = (1 * 5 * 5) + (1 * 10 * 10) = 125 elements
As they are two separate inputs.