Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytorch-forecasting and dsipts v2 API design #39

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update step.md
fkiraly committed Feb 1, 2025

Verified

This commit was signed with the committer’s verified signature.
nilsingwersen Nils Ingwersen
commit 69e83fce2d07809f45e1c53feca2e16c9c0c8860
8 changes: 5 additions & 3 deletions steps/25_pytorch_forecasting_dsipts/step.md
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ At the same time, the `dsip-ts` package (by agobbifbk) emerged, contributing int
of API uniformity, and a simple API.

It was decided that both packages - `pytorch-forecasting` and `dsip-ts` - would merge
with the aim to creat `pytorch-forecasting` - as the "sktime" of `torch` forecasting models.
with the aim to create `pytorch-forecasting v2` - as the "sktime" of `torch` forecasting models.

References:

@@ -97,7 +97,7 @@ This starts at data that is already pre-processed, re-sampled, batched.
* currently has two layers, a data layer and a model layer
* data layer = D1 plus D2 plus M (lasagna) = `TimeSeriesDataSet`
* model layer = T
* `BaseModel` is similar to C, but assumes data layer
* `BaseModel` is similar to M, but assumes data layer
* in particular, there is no uniformization layer for data or models that would cover, e.g., foundation models
* this also makes the design of very limited extensibility beyond certain decoder/encoder models

@@ -109,7 +109,7 @@ This starts at data that is already pre-processed, re-sampled, batched.
* model layer = T
* improvement compared to `pytorch-forecasting`, because there is a data uniformization layer
* but unfortunately D1 is not in the form of `DataSet` which would allow scaling
* model uniformization layer from layer D2, but not D1
* model uniformization layer from layer D2 onwards, but not D1


### mid-level interfaces
@@ -135,6 +135,8 @@ Design:

As implemented in draft [PR 1757](https://github.com/sktime/pytorch-forecasting/pull/1757)

Precise specs to be discussed.

```
Sampling via ``__getitem__`` returns a dictionary,
which always has following str-keyed entries: