Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Correct argument for optimizer ranger in Temporal Fusion Transformer tutorial #1724

Merged
merged 7 commits into from
Jan 20, 2025
Merged

[DOC] Correct argument for optimizer ranger in Temporal Fusion Transformer tutorial #1724

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b79952b
update the optimizer by passing correct argument
fnhirwa Dec 9, 2024
77ae575
Merge remote-tracking branch 'upstream/main' into docs
fnhirwa Dec 11, 2024
9775ebb
fix examples to run on cpu
fnhirwa Dec 11, 2024
2c70eea
try increasing the timeout
fnhirwa Dec 11, 2024
6d4c1ec
Merge remote-tracking branch 'upstream/main' into docs
fnhirwa Jan 6, 2025
96700e1
Merge remote-tracking branch 'upstream/main' into docs
fnhirwa Jan 14, 2025
baeea46
rerun example with latest changes on main
fnhirwa Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build_tools/run_examples.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# copy-paste from sktime's run_examples.sh
set -euxo pipefail

CMD="jupyter nbconvert --to notebook --inplace --execute --ExecutePreprocessor.timeout=600"
CMD="jupyter nbconvert --to notebook --inplace --execute --ExecutePreprocessor.timeout=1200"

for notebook in docs/source/tutorials/*.ipynb; do
echo "Running: $notebook"
Expand Down
5 changes: 5 additions & 0 deletions docs/source/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,3 +180,8 @@ def setup(app: Sphinx):
suppress_warnings = [
"autosummary.import_cycle",
]

# -----------nbsphinx extension ----------
nbsphinx_execute = "never" # always
nbsphinx_allow_errors = False # False
nbsphinx_timeout = 600 # seconds
999 changes: 785 additions & 214 deletions docs/source/tutorials/stallion.ipynb
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to see this diff in Github (it saus unable to render rich diff), and ReviewNB also seems to lack the notebook.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure about that, I logged in with my github and was able to see diff on ReviewNB
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it's not working for me, but not a big deal. I checked it from branch it directly.

I am not what change of yours is making the predictions worse. In main branch, the predicted orange line and shaded area seemed to contain the blue actuals pretty well, but in the modified one the gaps seem to have increased notably. Do you agree with observation? Any guess what's causing it (seed remained same at 42 in both cases)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the cause as I can see even the learning_rate got changed from 0.041 to 0.009. I think I'll need to check the logs and see where it is going wrong

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rerun the notebook now the losses seems to have been reduced

Large diffs are not rendered by default.

Loading