-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Accepting prereleases as valid python version #389
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 85.07% 85.77% +0.70%
==========================================
Files 45 48 +3
Lines 3015 3311 +296
==========================================
+ Hits 2565 2840 +275
- Misses 450 471 +21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Made minor update to the docstring for clarity.
I added a super minor change to mirror the exact code of sktime. (it was just an improved error message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you kindly add the tests here that are also present in the sktime
mirror of this?
Given that we will deduplicate with this as the ultimate location.
Solved :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor but consequential, breaking error above. Easy fix!
Reference Issues/PRs
Fixes: sktime/sktime#7517
Make "rc" python version recognizable during python version checking.
Introducing a parameter
prereleases=True
The following code snipped now returns true:
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
On the tests regarding checking python versions.
PR checklist
For all contributions
the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions