Skip to content

Commit

Permalink
[ENH] fix distribution row/column convention in CyclicBoosting (#334)
Browse files Browse the repository at this point in the history
Recent PR brought the QPDistributions in line with unified `skpro`
row/column conventions, where 1D vectors are interpreted as row vectors.

This clashes with assumed coercion about the now-changed QPDistributions
(it assumed column vectors) inside `CyclicBoosting`, which needed to be
fixed.
  • Loading branch information
fkiraly authored May 16, 2024
1 parent dad8793 commit 0b752e1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions skpro/regression/cyclic_boosting.py
Original file line number Diff line number Diff line change
Expand Up @@ -284,9 +284,9 @@ def _predict_proba(self, X):
# Johnson Quantile-Parameterized Distributions
params = {
"alpha": self.alpha,
"qv_low": self.quantile_values[0],
"qv_median": self.quantile_values[1],
"qv_high": self.quantile_values[2],
"qv_low": self.quantile_values[0].reshape(-1, 1),
"qv_median": self.quantile_values[1].reshape(-1, 1),
"qv_high": self.quantile_values[2].reshape(-1, 1),
"lower": self.lower,
"upper": self.upper,
"version": self.version,
Expand Down

0 comments on commit 0b752e1

Please sign in to comment.