Skip to content

Commit

Permalink
[ENH] update Johnson QPDistributions with bugfixes and vectorization …
Browse files Browse the repository at this point in the history
…(cyclic-boosting ver.1.4.0) (#232)

Fixes #190 and #188

#### What does this implement/fix? Explain your changes.
- Modfied QPD's methods following interface of vectorized QPD
- Bug fix tests for QPD
- replace scipy.misc.derivative to findiff because it will be removed in
scypy 1.12.0

#### Does your contribution introduce a new dependency? If yes, which
one?

yes, I have extras dependency 
findiff: https://findiff.readthedocs.io/en/latest/
  • Loading branch information
setoguchi-naoki authored May 14, 2024
1 parent 5421316 commit 3dae189
Show file tree
Hide file tree
Showing 7 changed files with 605 additions and 328 deletions.
1 change: 1 addition & 0 deletions docs/source/api_reference/distributions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ Non-parametric and empirical distributions
Delta
Empirical
QPD_Empirical
QPD_Johnson
QPD_U
QPD_S
QPD_B
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ all_extras = [
"statsmodels>=0.12.1",
"tabulate",
"uncertainties",
"cyclic-boosting>=1.2.5; python_version < '3.12'"
"cyclic-boosting>=1.4.0; python_version < '3.12'",
"findiff",
]

dev = [
Expand Down
4 changes: 3 additions & 1 deletion skpro/distributions/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
"""Probability distribution objects."""

# copyright: skpro developers, BSD-3-Clause License (see LICENSE file)
# adapted from sktime

Expand All @@ -18,6 +19,7 @@
"QPD_S",
"QPD_B",
"QPD_U",
"QPD_Johnson",
"TDistribution",
"Uniform",
"Weibull",
Expand All @@ -34,7 +36,7 @@
from skpro.distributions.mixture import Mixture
from skpro.distributions.normal import Normal
from skpro.distributions.poisson import Poisson
from skpro.distributions.qpd import QPD_B, QPD_S, QPD_U
from skpro.distributions.qpd import QPD_B, QPD_S, QPD_U, QPD_Johnson
from skpro.distributions.qpd_empirical import QPD_Empirical
from skpro.distributions.t import TDistribution
from skpro.distributions.uniform import Uniform
Expand Down
Loading

0 comments on commit 3dae189

Please sign in to comment.