Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] address deprecation of skbase.testing.utils.deep_equals #111

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Oct 7, 2023

This PR addresses deprecation (and removal in skbase 0.6.0) of skbase.testing.utils.deep_equals, by moving imports to the new location of the same module.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Oct 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0df7c6c) 71.67% compared to head (1f9b66d) 71.67%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   71.67%   71.67%           
=======================================
  Files          93       93           
  Lines        4950     4950           
  Branches      900      900           
=======================================
  Hits         3548     3548           
  Misses       1173     1173           
  Partials      229      229           
Files Coverage Δ
skpro/tests/test_all_estimators.py 84.05% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly merged commit dd4f17b into main Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants