-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] interfacing Poisson regressor from sklearn #213
Conversation
@fkiraly can you please approve changes? I will keep adding more linear models. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice idea!
However, I think more is needed to add the poisson regressor.
The current SklearnProbaReg
assumes a normal distribution, and predict
having an return_std
argument. This is not true for the sklearn PoissonRegressor
:
- the assumed return distribution is the Poisson distribution
predict
does not have areturn_std
, it simply returns the rate parameter.
To make this work, you would have to:
- add a tabular Poisson distribution to the
distributions
module - use that to encode the output of
predict
(the rate parameter)
@fkiraly thanks for the review, I will implement the changes soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abandoned - wrapped it up so it can be merged
Reference Issues/PRs
#7
What does this implement/fix? Explain your changes.
Added interface for Poisson Regressor
Does your contribution introduce a new dependency? If yes, which one?
None
Did you add any tests for the change?
None
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skpro
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst
, follow the pattern.Examples
section.python_dependencies
tag and ensureddependency isolation, see the estimator dependencies guide.