-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Chi-Squared Distribution #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice contribution!
Code formatting checks are failing, see here for a guide how to set this up locally:
https://www.sktime.net/en/stable/developer_guide/coding_standards.html
For the energy, let me know if you need help. Does the reference from the issue not have an explicit formula?
I do not understand what the build issue is, as it doesn't seem to show the files I modified, rather some other files |
note sure, I've restarted the tests - let's see. |
failures seem genuine - methods return unexpected values. Have you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Updated with new extension contract.
Reference Issues/PRs
Addresses #22 for chi-squared case
What does this implement/fix? Explain your changes.
Implements some methods for chi-squared distribution
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Current state of code, and what all capabilities need to be modified / made better (particularly, I am trying to implement energy and make ppf more native than a scipy wrapper)
Did you add any tests for the change?
Nope
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skpro
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release.See here for full badge reference
Thanks for contributing!
-->