[ENH] Syncing datatypes module _check.py and _convert.py with sktime
#432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
reviewed
Jul 24, 2024
fkiraly
reviewed
Jul 24, 2024
fkiraly
reviewed
Jul 24, 2024
fkiraly
reviewed
Jul 24, 2024
skpro/datatypes/_convert.py
Outdated
| f"which is {as_scitype}" | ||
| ) | ||
| to_type = same_scitype_mtypes[0] | ||
| # # if to_type is a list, we do the following: |
There was a problem hiding this comment.
why is this commented out? Can this not be entirely removed?
There was a problem hiding this comment.
impacts both skpro and sktime
There was a problem hiding this comment.
the comment out code was not used at all in the sktime _convert.py file. will remove it. I only commented it out and left it there to see if it would break anything if it was commented
fkiraly
requested changes
Jul 24, 2024
fkiraly
added
enhancement
module:datatypes
fkiraly
changed the title
_check.py and _convert.py to match sktime functionality_check.py and _convert.py with sktime
yarnabrina
pushed a commit
to sktime/sktime
that referenced
this pull request
Jul 28, 2024
…_mtype` function (#6835) Also added a input checker for `to_type` inside the `convert` function inside `_convert`. Relates to sktime/skpro#432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per requested by @fkiraly, we are updating the files
_check.pyand_convert.pyto match functionality with thesktimelibrary. Note that_common.pyis exactly the same for both libraries, so no changes were needed.This pr also should allow list of strings to be accepted as valid
X_inner_mtypeandy_inner_mtype.@fkiraly Could you please do a review to ensure that the code is correct?
Thanks!