-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #420 - Decrease per-test pytest timeout to 100 #456
base: main
Are you sure you want to change the base?
Issue #420 - Decrease per-test pytest timeout to 100 #456
Conversation
2853f1a
to
0e0604b
Compare
0e0604b
to
528efee
Compare
528efee
to
2ce0602
Compare
2ce0602
to
5a0fdee
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
==========================================
- Coverage 76.71% 76.70% -0.01%
==========================================
Files 247 247
Lines 63983 63983
Branches 5902 6024 +122
==========================================
- Hits 49083 49077 -6
+ Misses 12332 12329 -3
- Partials 2568 2577 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5a0fdee
to
92373cb
Compare
@jiridanek do you still want to do this ? Going from 400 to 100 ? I would rather not do this and find out that we need to move it back up again ? |
92373cb
to
a1273af
Compare
@ganeshmurthy This timeout is the default per-test timeout in pytest, so if you write a single python test method that takes more than 100 seconds, you can
IIRC, when this PR was newly created, there was one or two tests exceeding the 100 seconds, and I suspected in both cases it is because of some test bug, I don't exactly recall what it was. Looks like there is a few tests going over the 100 seconds. I'll try to look why they take that much time and if they truly need it, or if there is something wrong going on. |
a1273af
to
7750dbb
Compare
Failing tests need to be reviewed.