Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] add ability to set controller log level #1760

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from
Open

[v2] add ability to set controller log level #1760

wants to merge 2 commits into from

Conversation

Karen-Schoener
Copy link
Collaborator

Controller log level can be configured via a configmap.

Fixes #1698

@Karen-Schoener Karen-Schoener self-assigned this Oct 31, 2024
@Karen-Schoener Karen-Schoener marked this pull request as draft October 31, 2024 14:23
@Karen-Schoener
Copy link
Collaborator Author

With this PR, the user can optionally create configmap skupper-log-config in order to configure the skupper-controller log level.

If the configmap is not present, the v2 skupper-controller defaults the log level to INFO.

If the configmap is deleted, the skupper-controller sets the log level back to INFO.

@Karen-Schoener Karen-Schoener marked this pull request as ready for review October 31, 2024 19:33
@Karen-Schoener
[v2] add ability to set controller log level
f7768f2 
Controller log level can be configured via a configmap.

Fixes skupperproject#1698
grs
grs approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@grs grs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'SKUPPER_' prefix to the key may be a little redundant given the ConfigMap name is skupper-log-level, but this looks fine to me.

@Karen-Schoener
Copy link
Collaborator Author

The 'SKUPPER_' prefix to the key may be a little redundant given the ConfigMap name is skupper-log-level, but this looks fine to me.

Renamed SKUPPER_CONTROLLER_LOG_LEVEL to CONTROLLER_LOG_LEVEL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgiorgetti fgiorgetti fgiorgetti approved these changes

@grs grs grs approved these changes

@ssorj ssorj Awaiting requested review from ssorj

@ajssmith ajssmith Awaiting requested review from ajssmith

Assignees

@Karen-Schoener Karen-Schoener

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Karen-Schoener @grs @fgiorgetti