Allow reinitialization of font lock regexps #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `plantuml-mode`, initialization of the font locking regular expressions is done by asking the current version of plantuml for its supported keywords, builtins, etc. Every so often, this might fail for any reason, leaving the current Emacs session with invalid font lock information for plantuml. Redoing the initialization process is tedious, as the corresponding function `plantuml-init-once` does not allow for that to be done easily (one would have to undefine a lot of global variables to do so). This commit introduces a force parameter for `plantuml-init-once` to conduct reinitialization of all font lock information. It also moves regular expressions meant for indentation out of `plantuml-init-once`, as those are initialized by literal values that do not depend on any runtime information.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bump to make stale-bot happy. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
plantuml-mode, initialization of the font locking regular expressions isdone by asking the current version of plantuml for its supported keywords,
builtins, etc. Every so often, this might fail for any reason, leaving the
current Emacs session with invalid font lock information for plantuml. Redoing
the initialization process is tedious, as the corresponding function
plantuml-init-oncedoes not allow for that to be done easily (one would haveto undefine a lot of global variables to do so).
This commit introduces a force parameter for
plantuml-init-onceto conductreinitialization of all font lock information. It also moves regular
expressions meant for indentation out of
plantuml-init-once, as those areinitialized by literal values that do not depend on any runtime information.