Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent more note types #155

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

cynhr
Copy link

@cynhr cynhr commented Jan 3, 2022

Fixes #153 and fixes #154.

I agree to license any copyrightable changes made in this pull request under the GNU GPL v3 or later.

I have not run the test suite since Cask apparently isn't packaged on Guix and I'm a bit to tired to try and get it to run. I'm also not too familiar with all the PlantUML diagram languages, I might well have broken indentation somewhere else.
So maybe do some sanity checks before merging this.

cynhr added 2 commits January 3, 2022 22:56
Recognize named multiline notes in indentation regex.  These notes look
something like this:

note as N1
    some description
end note

Fixes: skuro#154
Recognize named multiline notes in indentation regex.  These notes look
something like this:

note top of Foo::bar
    some description
end note

This only supports a single "::".  In case multiple levels should be
supported, change the "?" to a "*".

Fixes: skuro#153
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 16, 2022
@cynhr
Copy link
Author

cynhr commented Apr 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

I do not understand how this issue (or any other issue for that matter) would be resolved by waiting without any action.

@stale stale bot removed the wontfix label Apr 23, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

indentation breaks after named multiline note indentation breaks after note anchored to method
1 participant