RLS-3715 VT-5648 Open Cart: Not All Products are Receiving Quantity Updates (issue for different versions) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slav
reviewed
Sep 14, 2022
|
|
||
| public static void Warning( Mark mark, string format, params object[] args ) | ||
| { | ||
| var markStr = $"[{mark}]\t"; |
There was a problem hiding this comment.
Should we fix templates to have all Capital Letters?
There was a problem hiding this comment.
@mrassudishkin - I still see {mark} instead of what I would've expected to be {Mark}. What did you fix?
dk-skuvault
approved these changes
Sep 20, 2022
slav
approved these changes
Sep 20, 2022
skuvault-bot
bot
changed the title
skuvault-bot
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[RLS-3715]
Issue: looks like we have three version of OpenCart. On the same API they returns different behavior and response.
What did I do here?
I added condition for searching unique items. I.e for accounts of type #1 we will receive all products in first request and will receive them again on second request. After that - we will break loop. I know that it isn't super idea, but I wasn't able to search any differences between responses for these accounts. These response doesn't have any version and etc.
[RLS-3715]: https://agileharbor.atlassian.net/browse/RLS-3715