89 queue buffer overflow #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheduler/src/main/scala/com/sky/kms/actors/PublisherActor.scala
Outdated
Show resolved
Hide resolved
| @@ -34,7 +43,27 @@ class PublisherActorSpec extends AkkaSpecBase with MockitoSugar { | |||
| expectTerminated(publisherActor) | |||
| } | |||
|
|
|||
| "do not offer when queue backpressures" in new TestContext { | |||
There was a problem hiding this comment.
Maybe I am missing it but what is the assertion in this test?
|
this just moves the buffer into the actors unbounded mailbox |
|
queue buffer overflow error generally just means the app is not configured appropriately to handle the load it is getting, with this change the buffer just becomes the actors mailbox so its the same really. Memory will just fill in the actors mailbox. You can get the same behaviour by just using max int for the buffer size, which is what is done in MAP iirc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #89
Publisher Actor now handles its internal queue's backpressuring when its buffer is full, thus avoiding the actor dying when it happens.