-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/prelight additions #7
Feat/prelight additions #7
Conversation
@@ -353,6 +353,7 @@ const AP_Param::GroupInfo AC_DroneShowManager::var_info[] = { | |||
static DroneShowLEDFactory _rgb_led_factory_singleton; | |||
|
|||
static bool is_safe_to_change_start_time_in_stage(DroneShowModeStage stage); | |||
static bool are_almost_equal(float a, float b); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiler didn't like comparisons of variables to float values. Maybe there is a utility that already provides this?
Judging from the code in I'm putting this PR on hold for the time being. If there's considerable interest from the community to merge this feature, drop a message here. In that case, some kind of an upgrade mechanism will have to be provided that re-writes the type of the parameter in the EEPROM from |
Proposal:
|
Yea, sorry. I already did this for my own builds. Guess I forgot to push up. |
Superseded by 36a3a2c in the |
Added percent brightness support to the
SHOW.PRE_LIGHTS
param. Existing integer values retain their level of brightness.