[WIP] Feature: TCPFactory/TCPTransport instead of dmsg #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdknives
requested changes
Jul 29, 2019
pkg/setup/node.go
Outdated
| @@ -30,7 +30,7 @@ type Node struct { | |||
| Logger *logging.Logger | |||
|
|
|||
| tm *transport.Manager | |||
| messenger *dmsg.Client | |||
| messenger transport.Factory | |||
There was a problem hiding this comment.
The setup node is supposed to use dmsg exclusively and directly. The communication between the visor and the setup node should not use TCP transport.
1. Rewritten with reverse index InMemoryTable 2. Fixed tests 3. Started integration environment for tcp-transport
Use ``` $ source ./integration/tcp-tr/env-vars.sh ``` to init and everything as usual
evanlinjin
reviewed
Aug 12, 2019
pkg/router/router.go
Outdated
| } | ||
| case "tcp-transport": | ||
| r.Logger.Info("Skipping setup for tcp-transport") | ||
| _, err := r.tm.CreateSetupTransport(context.Background(), raddr.PubKey, "tcp-transport") |
There was a problem hiding this comment.
dmsg is to be used with SetupNode always.
|
Just a thought, let's split this PR into two.
Let's make this PR be |
```zsh
$ for ((i=1; i<=128; i++)){_ ip addr add 12.12.12.$i/32 dev lo}
```
then run Example_runMultihead
```zsh
$ tree /tmp/multihead
$ cat /tmp/multihead/multihead.log |sort
$ ps aux |grep skychat |wc - l
```
You must see 128 instances of skywire-node with 128 skychats each on
different IP
…ltiHead.sendMessage
…egular calls. Debugging improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's WIP.
Just compiled and passes regular tests.
Closes: #501