[M2] app2 implementation #543

Darkren · 2019-08-30T07:28:59Z

Fixes #528

Added basic structures
Implemented methods for HSFrame

evanlinjin

📄

pkg/app2/hsframe.go

evanlinjin

Good start.

pkg/app2/client.go

pkg/app2/hsframe.go

pkg/app2/listener.go

pkg/app2/server.go

pkg/app2/listener.go

pkg/app2/server.go

… into feature/app2

evanlinjin

Beautifully written code.

Although there is some implementation queries. Specifically, we will need to support multiple networks in the future:

dmsg
skywire routes

My comments are mostly regarding this. Hence, you do not need to follow the exact comments, but please take some time to think of an optimal solution.

pkg/app2/server_rpc.go

pkg/app2/server_rpc_client.go

pkg/app2/client.go

pkg/app2/listener.go

pkg/app2/manager.go

pkg/app2/server_rpc.go

evanlinjin

Clean code and good work so far. Please review my comments.

pkg/app2/rpc_client.go

pkg/app2/client.go

pkg/app2/listener.go

pkg/app2/manager.go

pkg/app2/network/dmsg_conn.go

pkg/app2/rpc_gateway.go

evanlinjin

Good stuff. Nearly there.

pkg/app2/network/addr.go

pkg/app2/rpc_client.go

pkg/app2/client.go

Darkren added 2 commits August 30, 2019 09:48

Add basic structures

790571e

Add methods for HSFrame

5299283

evanlinjin reviewed Aug 30, 2019

View reviewed changes

pkg/app2/hsframe.go Outdated Show resolved Hide resolved

pkg/app2/hsframe.go Outdated Show resolved Hide resolved

evanlinjin added enhancement mainnet labels Aug 30, 2019

Darkren added 3 commits August 31, 2019 10:45

Fix PR queries

7deb42b

Add HSFrame tests

95a0d28

Add more work

804b770

evanlinjin changed the title ~~[WIP] app2 implementation~~ [M2] [WIP] app2 implementation Sep 4, 2019

Darkren added 2 commits September 6, 2019 14:14

Add yamux conn multiplexing

5029589

Add some shape to the client

972fa99

evanlinjin suggested changes Sep 9, 2019

View reviewed changes

Darkren added 2 commits September 9, 2019 15:56

Add some work on server

0a6506d

More work on app2

67ab801

evanlinjin reviewed Sep 10, 2019

View reviewed changes

pkg/app2/listener.go Outdated Show resolved Hide resolved

pkg/app2/server.go Outdated Show resolved Hide resolved

Darkren added 15 commits September 10, 2019 18:48

Move listen to lm, add Close to lm

a07d8a0

acceptedConn -> clientConn, clientConn -> serverConn

8dc1513

More work on app2

a282c5a

Add RPC server for server

e2afc9e

Finish RPC communication

f374c39

Add comments

7bcafc9

Impement net interfaces

cf5e105

Add proper port handling

f68b3e0

Remove freeLocalPort from Conn

a161a2d

Start to merge managers

a790f2c

Add more comments, finish manager

3e295fd

Start implementing manager tests

ca7fcae

Almost finish manager tests

1daf6c0

Add client tests

8b8ad33

Add conn tests

0e4a24a

Darkren added 3 commits September 18, 2019 13:28

Add Listener tests

f43c6bf

Refactor tests a bit

7ef6861

Merge branch 'mainnet-milestone2' of https://github.com/skycoin/skywire…

946a3dc

… into feature/app2

evanlinjin suggested changes Sep 18, 2019

View reviewed changes

Darkren added 6 commits September 20, 2019 17:26

Add networker stuff

f5986d5

Adjust code to the Networker usage

25489ef

Refactor a bit

eb42bca

Add more tests

0714e55

Add even more tests

3491994

And more tests

07d5b80

evanlinjin suggested changes Sep 23, 2019

View reviewed changes

Darkren added 7 commits September 23, 2019 14:22

Fix some queries

b2dcbbb

Finish RPC gateway tests

e243192

Add WrappedConn

f9c933f

Pass assigned local port from the server

34c6e29

Add conn/listener tracking

677fb24

Fix client tests

3a9fdba

Partially fix idManager tests

8c02d73

evanlinjin suggested changes Sep 24, 2019

View reviewed changes

pkg/app2/network/addr.go Outdated Show resolved Hide resolved

pkg/app2/network/addr.go Outdated Show resolved Hide resolved

pkg/app2/rpc_client.go Outdated Show resolved Hide resolved

pkg/app2/client.go Outdated Show resolved Hide resolved

pkg/app2/client.go Outdated Show resolved Hide resolved

Darkren added 4 commits September 25, 2019 13:02

Get rid of porter

d7e140b

Fix PR queries

17ba146

Fix tests

d560351

Add rpcClient tests

662c229

Darkren changed the title ~~[M2] [WIP] app2 implementation~~ [M2] app2 implementation Sep 26, 2019

Darkren merged commit 0ff83f9 into skycoin:mainnet-milestone2 Sep 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[M2] app2 implementation #543

[M2] app2 implementation #543

Darkren commented Aug 30, 2019

evanlinjin left a comment

evanlinjin left a comment

evanlinjin left a comment

evanlinjin left a comment

evanlinjin left a comment

[M2] app2 implementation #543

[M2] app2 implementation #543

Conversation

Darkren commented Aug 30, 2019

evanlinjin left a comment

Choose a reason for hiding this comment

evanlinjin left a comment

Choose a reason for hiding this comment

evanlinjin left a comment

Choose a reason for hiding this comment

evanlinjin left a comment

Choose a reason for hiding this comment

evanlinjin left a comment

Choose a reason for hiding this comment