Feature/route finder single route #568
Conversation
pkg/route-finder/client/client.go
Outdated
| MaxHops: maxHops, | ||
| // FindRoutes returns routes from source skywire visor to destiny, that has at least the given minHops and as much | ||
| // the given maxHops. | ||
| func (c *apiClient) FindRoutes(ctx context.Context, rts [][2]cipher.PubKey, opts *RouteOptions) ([][]routing.Route, error) { |
There was a problem hiding this comment.
Have the following changes:
- Create a new type
type Path []routing.Hop - Use the following as the output:
map[[2]cipher.PubKey][]routing.Path
We can run integration tests, no matter which one as long as we test that routes are being created. They are working on my tests. Basically run the following:
For unit testing the API however I think it would be better to write them on the server side. |
|
@nkryuchkov please give this a review and see if we can merge this into your work so far. Thanks! |
| return nil, err | ||
| } | ||
| res := bytes.NewBuffer(b1) | ||
| res.WriteString(":") // nolint |
There was a problem hiding this comment.
Although both WriteString and Write of bytes.Buffer always return nil as an error, I would explicitly check for an error here and below.
|
@evanlinjin I've already merged it into my work |
Should we close this PR then? |
|
@evanlinjin If it's to be merged in my work only, then yes. |
|
Already merged into #562 |
Closes #567