Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the Skychay UI to localhost #1605

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Conversation

Senyoret1
Copy link
Contributor

Changes:

  • Now the SkychatUI can only been opened from localhost or 127.0.0.1.

How to test this PR:
Recompile the UI and use it to open the Skychat UI. It will open it from 127.0.0.1.

Note: should this behaviour be configurable?

@0pcom
Copy link
Collaborator

0pcom commented Jun 6, 2023

I think we need to change this in either pkg/skyenv or pkg/visor/visorconfig. Basically it needs to populate in the config as localhost:8001 ; just to match what we have for other apps more or less

i believe it's configurable for skywire-cli config update but need to check it

@Senyoret1
Copy link
Contributor Author

The last commit adds a modal window were the user can select if it should be posible to access Skychat outside localhost and also allows to change the port.

@0pcom With this change, the config file need no modifications. If the config file has :8001, you can only access from localhost, but if the config file has *:8001, you can access from outside localhost, as before. Is there a a part of the CLI where that should be documented?

@Senyoret1
Copy link
Contributor Author

The last commit ask for confirmation before allowing the user to open the access to the Skychat app outside localhost.

@mrpalide mrpalide merged commit 7d0fd2e into skycoin:develop Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants