Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add skywire version to skywire-cli log #1669

Merged
merged 2 commits into from
Nov 2, 2023
Merged

add skywire version to skywire-cli log #1669

merged 2 commits into from
Nov 2, 2023

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Nov 1, 2023 •
edited
Loading

Did you run make format && make check? Yes

Fixes #1638

Changes:

  • add skywire version on error log in skywire-cli log commnad. We have same on not satisfied version, so we just add it for error on downloading files.

How to test this PR:

  • checkout to this branch
  • build by make build
  • run skywire-cli log

Output Example:

[2023-11-02T02:36:39.018016+03:30] ERROR [log-collecting]: The 2023-11-01.csv for visor 02132cb9f9b8d7f1441b04cbf27b78eff05c5c419efda177b5fe9a2843f8e107b5 not available. The version of visor is 1.3.13. error="http error: 404"

@mrpalide mrpalide linked an issue Nov 2, 2023 that may be closed by this pull request
print skywire version on skywire-cli log #1638
Closed
@jdknives jdknives merged commit 8bcb1bc into skycoin:develop Nov 2, 2023
3 checks passed
@mrpalide mrpalide deleted the fix/add-skywire-version-to-log-output-for-all-visors branch March 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

print skywire version on skywire-cli log
2 participants
@mrpalide @jdknives