Add selectByColor to ColorPickerController #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skydoves
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Currently the
HsvColorPickercolor is only updated by interacting with it. The only way we have to select a specific color without interacting with the picker is by setting aninitialColor. However, it may be useful to select a color at any time without interacting with the picker.🛠 Implementation details
This PR introduces the
selectByColor(color: Color, fromUser: Boolean)public method that allows to select acoloron the picker.fromUserenables notifying the color change. This method also updates the brightness. In this casefromUseris false to avoid notifying twice.I added an example on the
HsvColorPickerColoredSelectorScreen. There's a small palette of colors that can be clicked to select the same color on the picker.Screenshot