Skip to content

Commit

Permalink
fixes after review: add back "Bundle" suffit to dependencies bundle a…
Browse files Browse the repository at this point in the history
…nd use dashes instead of camel case for dependency component names.
  • Loading branch information
cbeyls committed May 15, 2024
1 parent cac69e7 commit 33d31d1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions core/network/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ dependencies {

// network
implementation(libs.sandwich)
implementation(libs.bundles.retrofit)
testImplementation(libs.okhttp.mockserver)
implementation(libs.bundles.retrofitBundle)
testImplementation(libs.okhttp.mockwebserver)
testImplementation(libs.androidx.arch.core.testing)

// json parsing
Expand Down
8 changes: 4 additions & 4 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ hilt-compiler = { module = "com.google.dagger:hilt-compiler", version.ref = "hil
hilt-testing = { module = "com.google.dagger:hilt-android-testing", version.ref = "hilt" }
sandwich = { module = "com.github.skydoves:sandwich-retrofit", version.ref = "sandwich" }
retrofit = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit" }
retrofit-kotlinSerialization = { module = "com.squareup.retrofit2:converter-kotlinx-serialization", version.ref = "retrofit" }
okhttp-loggingInterceptor = { module = "com.squareup.okhttp3:logging-interceptor", version.ref = "okHttp" }
okhttp-mockserver = { module = "com.squareup.okhttp3:mockwebserver", version.ref = "okHttp" }
retrofit-kotlin-serialization = { module = "com.squareup.retrofit2:converter-kotlinx-serialization", version.ref = "retrofit" }
okhttp-logging-interceptor = { module = "com.squareup.okhttp3:logging-interceptor", version.ref = "okHttp" }
okhttp-mockwebserver = { module = "com.squareup.okhttp3:mockwebserver", version.ref = "okHttp" }
kotlinx-coroutines-android = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-android", version.ref = "coroutines" }
kotlinx-coroutines-test = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-test", version.ref = "coroutines" }
kotlinx-immutable-collection = { group = "org.jetbrains.kotlinx", name = "kotlinx-collections-immutable", version.ref = "kotlinxImmutable" }
Expand Down Expand Up @@ -106,4 +106,4 @@ hilt-plugin = { id = "com.google.dagger.hilt.android", version.ref = "hilt" }
baselineprofile = { id = "androidx.baselineprofile", version.ref = "baselineprofile" }

[bundles]
retrofit = ["retrofit", "retrofit-kotlinSerialization", "okhttp-loggingInterceptor"]
retrofitBundle = ["retrofit", "retrofit-kotlin-serialization", "okhttp-logging-interceptor"]

0 comments on commit 33d31d1

Please sign in to comment.