Skip to content

Commit

Permalink
fix storage CLIs
Browse files Browse the repository at this point in the history
  • Loading branch information
Michaelvll committed Aug 5, 2024
1 parent 678fff2 commit 08104be
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 1 deletion.
13 changes: 13 additions & 0 deletions sky/api/requests/decoders.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

from sky import jobs as managed_jobs
from sky.clouds.service_catalog import common
from sky.data import storage
from sky.serve import serve_state
from sky.skylet import job_lib
from sky.utils import registry
Expand Down Expand Up @@ -129,3 +130,15 @@ def decode_list_accelerators(
instance_dict[gpu].append(
common.InstanceTypeInfo(*instance_type_info))
return instance_dict


@register_handler('storage_ls')
def decode_storage_ls(
return_value: List[Dict[str, Any]]) -> List[Dict[str, Any]]:
for storage_info in return_value:
storage_info['status'] = status_lib.StorageStatus(
storage_info['status'])
storage_info['store'] = [
storage.StoreType(store) for store in storage_info['store']
]
return return_value
8 changes: 8 additions & 0 deletions sky/api/requests/encoders.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,11 @@ def encode_cost_report(
def encode_enabled_clouds(clouds: List['clouds.Cloud']) -> List[str]:
enabled_clodus_list = [str(cloud) for cloud in clouds]
return enabled_clodus_list


@register_handler('storage_ls')
def encode_storage_ls(return_value: List[Dict[str, Any]]) -> List[str]:
for storage_info in return_value:
storage_info['status'] = storage_info['status'].value
storage_info['store'] = [store.value for store in storage_info['store']]
return return_value
2 changes: 1 addition & 1 deletion sky/api/rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ async def storage_ls(request: fastapi.Request):
)


@app.get('/storage/delete')
@app.post('/storage/delete')
async def storage_delete(request: fastapi.Request,
storage_body: payloads.StorageBody):
executor.start_background_request(
Expand Down

0 comments on commit 08104be

Please sign in to comment.