Skip to content

Commit

Permalink
[Core] Deprecate LocalDockerBackend (#4516)
Browse files Browse the repository at this point in the history
Deprecate local docker backend
  • Loading branch information
romilbhardwaj authored Dec 30, 2024
1 parent 7e40bcd commit 13501e2
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 62 deletions.
19 changes: 0 additions & 19 deletions examples/local_docker/docker_in_docker.yaml

This file was deleted.

22 changes: 0 additions & 22 deletions examples/local_docker/ping.py

This file was deleted.

19 changes: 0 additions & 19 deletions examples/local_docker/ping.yaml

This file was deleted.

11 changes: 9 additions & 2 deletions sky/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -998,8 +998,10 @@ def cli():
@click.option('--docker',
'backend_name',
flag_value=backends.LocalDockerBackend.NAME,
default=False,
help='If used, runs locally inside a docker container.')
hidden=True,
help=('(Deprecated) Local docker support is deprecated. '
'To run locally, create a local Kubernetes cluster with '
'``sky local up``.'))
@_add_click_options(_TASK_OPTIONS_WITH_NAME + _EXTRA_RESOURCES_OPTIONS)
@click.option(
'--idle-minutes-to-autostop',
Expand Down Expand Up @@ -1142,6 +1144,11 @@ def launch(
backend: backends.Backend
if backend_name == backends.LocalDockerBackend.NAME:
backend = backends.LocalDockerBackend()
click.secho(
'WARNING: LocalDockerBackend is deprecated and will be '
'removed in a future release. To run locally, create a local '
'Kubernetes cluster with `sky local up`.',
fg='yellow')
elif backend_name == backends.CloudVmRayBackend.NAME:
backend = backends.CloudVmRayBackend()
else:
Expand Down

0 comments on commit 13501e2

Please sign in to comment.