Skip to content

Commit

Permalink
Allow uppercase letters in task names (#3453)
Browse files Browse the repository at this point in the history
The error message specifically states that upper case letters are allowed, but the regex previously did not allow them.
  • Loading branch information
Harthgar authored Apr 20, 2024
1 parent 6eb1d97 commit 281e489
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sky/task.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
CommandGen = Callable[[int, List[str]], Optional[str]]
CommandOrCommandGen = Union[str, CommandGen]

_VALID_NAME_REGEX = '[a-z0-9]+(?:[._-]{1,2}[a-z0-9]+)*'
_VALID_NAME_REGEX = '[a-zA-Z0-9]+(?:[._-]{1,2}[a-zA-Z0-9]+)*'
_VALID_NAME_DESCR = ('ASCII characters and may contain lowercase and'
' uppercase letters, digits, underscores, periods,'
' and dashes. Must start and end with alphanumeric'
Expand Down

0 comments on commit 281e489

Please sign in to comment.