Skip to content

Commit

Permalink
[BugFix] Fix GCP Cloud Permission doc url (#2770)
Browse files Browse the repository at this point in the history
fix
  • Loading branch information
cblmemo authored Nov 11, 2023
1 parent 51a831c commit 31aa76c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion sky/backends/cloud_vm_ray_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@ def _update_blocklist_on_gcp_error(
'having the required permissions and the user '
'account does not have enough permission to '
'update it. Please contact your administrator and '
'check out: https://skypilot.readthedocs.io/en/latest/cloud-setup/cloud-permissions.html#gcp\n' # pylint: disable=line-too-long
'check out: https://skypilot.readthedocs.io/en/latest/cloud-setup/cloud-permissions/gcp.html\n' # pylint: disable=line-too-long
f'Details: {httperror_str[0]}')
self._blocked_resources.add(
launchable_resources.copy(region=None, zone=None))
Expand Down
2 changes: 1 addition & 1 deletion sky/clouds/gcp.py
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@ def check_credentials(cls) -> Tuple[bool, Optional[str]]:
'The following permissions are not enabled for the current '
f'GCP identity ({identity_str}):\n '
f'{diffs}\n '
'For more details, visit: https://skypilot.readthedocs.io/en/latest/cloud-setup/cloud-permissions.html#gcp') # pylint: disable=line-too-long
'For more details, visit: https://skypilot.readthedocs.io/en/latest/cloud-setup/cloud-permissions/gcp.html') # pylint: disable=line-too-long
return True, None

def get_credential_file_mounts(self) -> Dict[str, str]:
Expand Down
2 changes: 1 addition & 1 deletion sky/skylet/providers/gcp/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
]

# A list of permissions required to run SkyPilot on GCP.
# Keep this in sync with https://skypilot.readthedocs.io/en/latest/cloud-setup/cloud-permissions.html#gcp # pylint: disable=line-too-long
# Keep this in sync with https://skypilot.readthedocs.io/en/latest/cloud-setup/cloud-permissions/gcp.html # pylint: disable=line-too-long
VM_MINIMAL_PERMISSIONS = [
"compute.disks.create",
"compute.disks.list",
Expand Down

0 comments on commit 31aa76c

Please sign in to comment.