Skip to content

Commit

Permalink
[Core] Bug fix for Tag Values representing booleans being loaded as b…
Browse files Browse the repository at this point in the history
…oolean instead of strings (#3482)

fix: string that represents boolean being loaded as boolean
  • Loading branch information
JGSweets authored Apr 26, 2024
1 parent 1e5246d commit 32631ff
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions sky/templates/aws-ray.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ available_node_types:
Value: {{ user }}
{%- for tag_key, tag_value in instance_tags.items() %}
- Key: {{ tag_key }}
Value: {{ tag_value }}
Value: {{ tag_value|tojson }}
{%- endfor %}

head_node_type: ray.head.default
Expand Down Expand Up @@ -161,5 +161,3 @@ setup_commands:

# Command to start ray clusters are now placed in `sky.provision.instance_setup`.
# We do not need to list it here anymore.


2 changes: 1 addition & 1 deletion sky/templates/gcp-ray.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ available_node_types:
labels:
skypilot-user: {{ user }}
{%- for tag_key, tag_value in instance_tags.items() %}
{{ tag_key }}: {{ tag_value }}
{{ tag_key }}: {{ tag_value|tojson }}
{%- endfor %}
{%- if specific_reservations %}
reservationAffinity:
Expand Down

0 comments on commit 32631ff

Please sign in to comment.