[SkyServe][Test] Fix test_smoke.py::test_skyserve_new_autoscaler_upda…

…te (#3824)

* fix test_smoke.py::test_skyserve_new_autoscaler_update

* nit

* format

* move out the comment from run at new_autoscaler_after.yaml

* revert comment

* revert templating

* nit

* nit

tests/skyserve/update/new_autoscaler_after.yaml

@@ -8,7 +8,6 @@ service:
     base_ondemand_fallback_replicas: 1
 
 resources:
-  cloud: gcp
   ports: 8081
   use_spot: true
   cpus: 2+
@@ -22,4 +21,4 @@ run: |
     # blue-green update.
     sleep 120
   fi
-  python3 server.py
+  python3 server.py --port 8081

tests/skyserve/update/new_autoscaler_before.yaml

@@ -5,10 +5,9 @@ service:
   replicas: 2
 
 resources:
-  cloud: gcp
   ports: 8081
   cpus: 2+
 
 workdir: examples/serve/http_server
 
-run: python3 server.py
+run: python3 server.py --port 8081

tests/test_smoke.py

@@ -3952,7 +3952,7 @@ def test_skyserve_update_autoscale(generic_cloud: str):
 @pytest.mark.parametrize('mode', ['rolling', 'blue_green'])
 def test_skyserve_new_autoscaler_update(mode: str, generic_cloud: str):
     """Test skyserve with update that changes autoscaler"""
-    name = _get_service_name() + mode
+    name = f'{_get_service_name()}-{mode}'
 
     wait_until_no_pending = (
         f's=$(sky serve status {name}); echo "$s"; '
@@ -3982,7 +3982,7 @@ def test_skyserve_new_autoscaler_update(mode: str, generic_cloud: str):
             _check_service_version(name, "1"),
         ]
     test = Test(
-        'test-skyserve-new-autoscaler-update',
+        f'test-skyserve-new-autoscaler-update-{mode}',
         [
             f'sky serve up -n {name} --cloud {generic_cloud} -y tests/skyserve/update/new_autoscaler_before.yaml',
             _SERVE_WAIT_UNTIL_READY.format(name=name, replica_num=2) +