Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
sunny0826 committed Sep 14, 2023
1 parent 21c3233 commit 72d807f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
6 changes: 3 additions & 3 deletions docs/source/reference/faq.rst
Original file line number Diff line number Diff line change
Expand Up @@ -103,19 +103,19 @@ By default, SkyPilot supports most global regions on AWS and only supports the U
version=$(python -c 'import sky; print(sky.clouds.service_catalog.constants.CATALOG_SCHEMA_VERSION)')
mkdir -p ~/.sky/catalogs/${version}
cd ~/.sky/catalogs/${version}
# Fetch the US region for GCP
# Fetch U.S. regions region for GCP
python -m sky.clouds.service_catalog.data_fetchers.fetch_gcp
# Fetch all regions for GCP
pip install lxml
python -m sky.clouds.service_catalog.data_fetchers.fetch_gcp --all-regions
# Fetch the US region for Azure
# Fetch U.S. regions region for Azure
python -m sky.clouds.service_catalog.data_fetchers.fetch_azure
# Fetch all regions for Azure
python -m sky.clouds.service_catalog.data_fetchers.fetch_azure --all-regions
# Fetch the specified regions for Azure
python -m sky.clouds.service_catalog.data_fetchers.fetch_azure --regions japaneast australiaeast uksouth
# Exclude the specified regions for Azure
# Fetch U.S. regions for Azure, excluding the specified regions
python -m sky.clouds.service_catalog.data_fetchers.fetch_azure --exclude centralus eastus
To make your managed spot jobs potentially use all global regions, please log into the spot controller with ``ssh sky-spot-controller-<hash>``
Expand Down
5 changes: 4 additions & 1 deletion sky/clouds/service_catalog/data_fetchers/fetch_azure.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,12 @@ def get_additional_columns(row):
region_filter = set(get_regions()) - EXCLUDED_REGIONS
else:
region_filter = US_REGIONS
region_filter = set(region_filter) - set(
region_filter = region_filter - set(
args.exclude) if args.exclude else region_filter

if not region_filter:
raise ValueError('No regions to fetch. Please check your arguments.')

instance_df = get_all_regions_instance_types_df(region_filter)
os.makedirs('azure', exist_ok=True)
instance_df.to_csv('azure/vms.csv', index=False)
Expand Down

0 comments on commit 72d807f

Please sign in to comment.