Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Zhanghao Wu <[email protected]>
  • Loading branch information
cblmemo and Michaelvll authored Sep 15, 2023
1 parent 21a448c commit 8e637c5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion sky/backends/cloud_vm_ray_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -2874,7 +2874,7 @@ def _get_zone(runner):
to_provision_config.ports_to_open, lock_path)
return handle

def _open_inexistent_ports(self, handle: CloudVmRayResourceHandle,
def _open_nonexistent_ports(self, handle: CloudVmRayResourceHandle,
ports_to_open: List[str]) -> None:
cloud = handle.launched_resources.cloud
if not isinstance(cloud, (clouds.AWS, clouds.GCP, clouds.Azure)):
Expand Down
1 change: 1 addition & 0 deletions sky/provision/azure/instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

def get_azure_sdk_function(client: Any, function_name: str) -> Callable:
"""Retrieve a callable function from Azure SDK client object.
Newer versions of the various client SDKs renamed function names to
have a begin_ prefix. This function supports both the old and new
versions of the SDK by first trying the old name and falling back to
Expand Down

0 comments on commit 8e637c5

Please sign in to comment.