Skip to content

Commit

Permalink
small fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
JungleCatSW committed Jan 4, 2024
1 parent b90fff8 commit 8ef426c
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 11 deletions.
4 changes: 2 additions & 2 deletions sky/clouds/cudo.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class Cudo(clouds.Cloud):

@classmethod
def _unsupported_features_for_resources(
cls, resources: 'resources_lib.Resources'
cls, resources: 'resources_lib.Resources'
) -> Dict[clouds.CloudImplementationFeatures, str]:
features = {
clouds.CloudImplementationFeatures.CLONE_DISK_FROM_CLUSTER:
Expand All @@ -63,7 +63,7 @@ def _unsupported_features_for_resources(
'`run` section in task.yaml.'),
clouds.CloudImplementationFeatures.CUSTOM_DISK_TIER:
(f'Custom disk tier is currently not supported on {cls._REPR}.'
),
),
clouds.CloudImplementationFeatures.OPEN_PORTS:
(f'Opening ports is currently not supported on {cls._REPR}.'),
}
Expand Down
14 changes: 7 additions & 7 deletions sky/clouds/service_catalog/cudo_catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,14 @@ def get_region_zones_for_instance_type(instance_type: str,


def list_accelerators(
gpus_only: bool,
name_filter: Optional[str] = None,
region_filter: Optional[str] = None,
quantity_filter: Optional[int] = None,
case_sensitive: bool = True,
all_regions: bool = False,
gpus_only: bool,
name_filter: Optional[str] = None,
region_filter: Optional[str] = None,
quantity_filter: Optional[int] = None,
case_sensitive: bool = True,
all_regions: bool = False,
) -> Dict[str, List[common.InstanceTypeInfo]]:
"""Returns all instance types in Cudo offering GPUs."""
return common.list_accelerators_impl('Cudo', _df, gpus_only, name_filter,
region_filter, quantity_filter,
case_sensitive)
case_sensitive, all_regions)
5 changes: 3 additions & 2 deletions sky/skylet/providers/cudo/cudo_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@ def set_tags(instance_id: str, tags: Dict):
api = cudo_api.virtual_machines()
api.update_vm_metadata(
cudo_api.project_id(), instance_id,
UpdateVMMetadataBody(metadata=tags,
merge=True)) # TODO (skypilot team) merge or overwrite?
UpdateVMMetadataBody(
metadata=tags,
merge=True)) # TODO (skypilot team) merge or overwrite?
except ApiException as e:
raise e

Expand Down

0 comments on commit 8ef426c

Please sign in to comment.