comments

skypilot-org · Mar 25, 2024 · ba971ad · ba971ad
1 parent 9820a9c
commit ba971ad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/sky/data/data_utils.py b/sky/data/data_utils.py
@@ -90,7 +90,7 @@ def split_cos_path(s3_path: str) -> Tuple[str, str, str]:
     return bucket_name, data_path, region
 
 
-def create_s3_client(region: Optional[str] = 'us-east-1') -> Client:
+def create_s3_client(region: Optional[str] = None) -> Client:
     """Helper method that connects to Boto3 client for S3 Bucket
 
     Args:

diff --git a/tests/test_smoke.py b/tests/test_smoke.py
@@ -3783,14 +3783,13 @@ def cli_region_cmd(store_type, bucket_name):
         if store_type == storage_lib.StoreType.S3:
             return ('aws s3api get-bucket-location '
                     f'--bucket {bucket_name} --output text')
-        if store_type == storage_lib.StoreType.GCS:
+        elif store_type == storage_lib.StoreType.GCS:
             return (f'gsutil ls -L -b gs://{bucket_name}/ | '
                     'grep "Location constraint" | '
                     'awk \'{print tolower($NF)}\'')
-        if store_type == storage_lib.StoreType.R2:
-            raise NotImplementedError
-        if store_type == storage_lib.StoreType.IBM:
-            raise NotImplementedError
+        else:
+            raise NotImplementedError(f'Region command not implemented for '
+                                      f'{store_type}')
 
     @staticmethod
     def cli_count_name_in_bucket(store_type, bucket_name, file_name, suffix=''):