Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP] Add --regions and --exclude flag to fetch_gcp #2555

Closed
sunny0826 opened this issue Sep 14, 2023 · 0 comments · Fixed by #2562
Closed

[GCP] Add --regions and --exclude flag to fetch_gcp #2555

sunny0826 opened this issue Sep 14, 2023 · 0 comments · Fixed by #2562

Comments

@sunny0826
Copy link
Contributor

See #2553 (review)

Add --regions and --exclude flag to fetch_gcp.

--regions: Fetch the list of specified regions.
--exclude: Exclude the list of specified regions.

example:

# Fetch the specified regions for GCP
python -m sky.clouds.service_catalog.data_fetchers.fetch_gcp --regions us-central2 us-central1 us-east1
# Exclude the specified regions for GCP
python -m sky.clouds.service_catalog.data_fetchers.fetch_gcp --exclude us-east4

Referable code: sky/clouds/service_catalog/data_fetchers/fetch_azure.py
@sunny0826 sunny0826 mentioned this issue Sep 14, 2023
Merged
sunny0826 added a commit to sunny0826/skypilot that referenced this issue Sep 15, 2023
@sunny0826
feat: 🎸 Add --zones and --exclude flag to fetch_gcp
3afc3a2 
✅ Closes: skypilot-org#2555
@sunny0826 sunny0826 mentioned this issue Sep 15, 2023
Merged
iojw added a commit that referenced this issue Sep 21, 2023
@sunny0826 @iojw
feat: 🎸 Add --zones and --exclude flag to fetch_gcp (#2562)
b6fc1ec 
* feat: 🎸 Add --zones and --exclude flag to fetch_gcp

✅ Closes: #2555

* fix

* fix

* fix

* fix

* fix

* Clean up comments

* Lint

---------

Co-authored-by: Isaac Ong <[email protected]>
@sunny0826 sunny0826 mentioned this issue Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 🎸 Add --zones and --exclude flag to fetch_gcp sunny0826/skypilot
1 participant
@sunny0826