-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 Add --regions and --exclude flag to fetch_azure #2553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @sunny0826! I've left some comments.
Could also also create a new issue to add the same flags for the GCP fetching script? It would be good to have parity across these 2 scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sunny0826! Just some minor nits, this is almost good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sunny0826! I made some minor fixes but this is good to go. It will be very helpful for the future.
refer #2549
Add
--regions
and--exclude
flag tofetch_azure
.--regions
: Fetch the list of specified regions.--exclude
: Exclude the list of specified regions.example: