Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 Add --regions and --exclude flag to fetch_azure #2553

Merged
merged 10 commits into from
Sep 14, 2023

Conversation

sunny0826
Copy link
Contributor

@sunny0826 sunny0826 commented Sep 13, 2023

refer #2549
Add --regions and --exclude flag to fetch_azure.

--regions: Fetch the list of specified regions.
--exclude: Exclude the list of specified regions.

example:

# Fetch the specified regions for Azure
python -m sky.clouds.service_catalog.data_fetchers.fetch_azure --regions japaneast australiaeast uksouth
# Exclude the specified regions for Azure
python -m sky.clouds.service_catalog.data_fetchers.fetch_azure --exclude centralus eastus

Copy link
Collaborator

@iojw iojw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @sunny0826! I've left some comments.

Could also also create a new issue to add the same flags for the GCP fetching script? It would be good to have parity across these 2 scripts.

.gitignore Outdated Show resolved Hide resolved
docs/source/reference/faq.rst Outdated Show resolved Hide resolved
sky/clouds/service_catalog/data_fetchers/fetch_azure.py Outdated Show resolved Hide resolved
sky/clouds/service_catalog/data_fetchers/fetch_azure.py Outdated Show resolved Hide resolved
@sunny0826
Copy link
Contributor Author

@iojw An Issue #2555 about GCP has been created.

Copy link
Collaborator

@iojw iojw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sunny0826! Just some minor nits, this is almost good to go.

docs/source/reference/faq.rst Outdated Show resolved Hide resolved
docs/source/reference/faq.rst Outdated Show resolved Hide resolved
docs/source/reference/faq.rst Outdated Show resolved Hide resolved
sky/clouds/service_catalog/data_fetchers/fetch_azure.py Outdated Show resolved Hide resolved
sky/clouds/service_catalog/data_fetchers/gcp/vms.csv Outdated Show resolved Hide resolved
docs/source/reference/faq.rst Outdated Show resolved Hide resolved
docs/source/reference/faq.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@iojw iojw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sunny0826! I made some minor fixes but this is good to go. It will be very helpful for the future.

@iojw iojw merged commit 4cd0d45 into skypilot-org:master Sep 14, 2023
@sunny0826 sunny0826 deleted the feat/fetch-azure-flag branch September 15, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants