Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[K8s] Zero config networking for Kubernetes #2500
[K8s] Zero config networking for Kubernetes #2500
Changes from 204 commits
0431f96
5f715e8
197acea
f06b22d
cf1ddec
0937cc3
40aad6d
47d0953
9f59467
07f9bcb
bd12014
4baf0b6
b08eb1b
7ed02eb
898a851
fcb51d1
13eb198
428f143
ebf9d83
da570fc
1bea866
9def756
8f9cafe
65366eb
b984ead
3bca8a9
61df297
036eaf9
95e160c
301a914
2c88daf
7ece7f7
cc85f94
0450cee
f3f0578
574a9c6
0632b48
05508d3
fb36a40
7db4027
632ed30
d7bd766
1a444d1
da9cba2
81871ac
0d1c4ac
8017020
5d7f8e8
aa787f8
c026559
3dc80d2
63ce29b
f9d5b73
b81647a
050cfc2
d64c394
7367b4a
756c56c
d4c0990
b64dd19
10333d7
b07fc58
5af58aa
4d6710f
c057c88
b8e414e
c2ebfe7
1fc857b
0ae92eb
10f302f
2a4caac
54b2b28
fc362b7
36f9ebc
5ee821d
d6ca85a
fbae4bf
6e9e6ba
7fa9d7e
a3f827e
9687ea8
4b54555
f73f1b2
0c45b9a
a69df01
ff1d832
6a931e2
662e4b9
4046749
92d588d
9ff1662
364b03f
691f6b7
ed0741f
3fe9bfb
b98ced3
07ea97d
73ee737
7726850
2ee4833
9e0f5b6
b36fba4
c137360
a806b39
a9b9636
7903339
4ab5329
4b49241
83aecd3
bdeb7d5
993f736
4fb1d94
02e3415
c1b7438
b9701ca
4289462
3d770bd
25f84b1
2875ff9
1202c34
d8e5bd2
d1a6ef4
b3fcadc
4a7d5d7
85ee1e1
d95438b
607ad85
6f702da
738ae19
9cdbf86
c3420a8
c87c64d
85f2b9e
509fd96
22b1d17
552481c
33b29b8
e65d3c1
82327fb
22fc6ad
3e9656a
be3d905
277295a
69168dd
cfe2502
3004951
b76b3a6
7207c34
56ac60f
d988307
a208d91
c857a9d
ee89f65
8934b22
9b5019b
53e5d80
f806aed
4bf43ee
429eed4
8dd1a76
df10bc6
512d9fb
858eb51
96647bf
fdff1a6
1b8385c
3ef135a
7b638cc
7da33e4
5d4d27c
e9d0ed1
f21b50a
f736236
7b5d0b5
8a3d5a7
58b8126
f9b401e
950de00
292a350
c17f854
330c3b4
d760676
f2ea761
9d34ff7
5b5aacd
aae4676
2eedca6
b07748d
e379291
482a69d
fb09398
a721f83
9a1cdbe
c620f94
94bf1a9
48d53a5
08fd88d
693af6d
582b484
33439e3
d214495
4e8b678
21cee8b
d8302f0
c7e8429
fd2976a
9827bbb
f74c9df
657cd6f
9c4e338
add29dd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does removing this mean the
NodePort
mode will not work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, NodePort would still work - it's just that now everything goes through a SSH Jump Pod, so the SSH port remains fixed at 22 and we don't need to get port here. Note that the jump port is dynamic and is fetched in
kubernetes_utils.get_ssh_proxy_command
at provisioning time.