Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Run GPU labelling job only on nodes with gpus #2550

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

romilbhardwaj
Copy link
Collaborator

Previously python -m sky.utils.kubernetes.gpu_labeler would also try to run jobs on nodes without GPUs, which would require a manual clean up with python -m sky.utils.kubernetes.gpu_labeler --cleanup since those jobs would never complete.

This PR filters and runs gpu labelling jobs only on nodes with GPUs.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Tested on GKE and EKS cluster

@romilbhardwaj romilbhardwaj added this to the 0.4 milestone Sep 15, 2023
Copy link
Collaborator

@landscapepainter landscapepainter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried out and confirmed it works smoothly. With this filtering, do we need to update L85 from tests/kubernetes/README.md as well?
Note that some jobs may be in pending state if your cluster contains CPU nodes.

@romilbhardwaj
Copy link
Collaborator Author

Thanks @landscapepainter! Merging now.

@romilbhardwaj romilbhardwaj merged commit 578b36d into master Sep 16, 2023
18 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_gpu_labeler_gpuonlynode branch September 16, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants